Invoke terminate function for edge buttons if button is released.(Resolved)

[charlie]

To Danny Baumann. Please revert comit 9964fd99b3e9fdc242ea57c4baf0109694213458 (Invoke terminate function for edge buttons if button is released.) Tue, 4 Mar 2008 14:29:22 +0000 (15:29 +0100).

I believe the above comit disables the ability to cycle through more than two windows by use of a mouse button and screen edge under the Ring Switcher plugin.

To test fuctionality: set in ccsm/Ring Switcher/Key bindings/mouse Next Window(All Workspaces) to <RightEdge>Button1

When clicking on the right edge of the screen the ring switcher should cycle through all windows and then the ring switcher should only terminate when the mouse cursor is removed away from the right screen edge and not terminate on a Button1 release.

[maniac]

To Danny Baumann. Please revert comit 9964fd99b3e9fdc242ea57c4baf0109694213458 (Invoke terminate function for edge buttons if button is released.) Tue, 4 Mar 2008 14:29:22 +0000 (15:29 +0100).

I believe the above comit disables the ability to cycle through more than two windows by use of a mouse button and screen edge under the Ring Switcher plugin.

That's true, but I won't revert this commit nevertheless, simply because it's correct: If an action is triggered by both button and edge, the plugin should be able to decide if the action should be terminated by edge or button.


To test fuctionality: set in ccsm/Ring Switcher/Key bindings/mouse Next Window(All Workspaces) to <RightEdge>Button1

When clicking on the right edge of the screen the ring switcher should cycle through all windows and then the ring switcher should only terminate when the mouse cursor is removed away from the right screen edge and not terminate on a Button1 release.
I've pushed a change to the ring switcher that should fix this. Let me know if it works for you as well.

[charlie]

It works again. Thanks for your time.