Application window switcher patch - doesn't work

[RAOF]

Hello all.

I've got a small patch for switcher.c to add an "application windows" switch - basically, it should switch between the windows of the active application (through your gnome-terminals, for example).

The code is modeled on scale's "Group" mode, which does exactly this.

The trouble is, the action doesn't seem to be hooked up properly. It doesn't break anything, but Super-Tab doesn't activate next_app.

As far as I can tell, it should be hooked up in the same way as all the other switcher options. Can anyone with a bit more experience help? The patch is here: http://raof.dyndns.org/code/app-switch.patch

[mikedee]

The patch isnt loading - server down :(

[RAOF]

Aargh. Why can't you upload to this forum? :(

Anyway, the patch is hosted on my home box, which is turned off while I'm sleeping.

Its up from 8am -> 10pm ish (GMT+11, so that's 9pm -> 11am GMT) most days.

If those times don't mesh with anyone's patch-review times, I'll just post it to the mailing list. Since this is the first time I've done anything with compiz, though, I'm pretty sure it's something trivial which I've failed to understand.

[mikedee]

I made it work by changing this line

o->value.action.type = 0;

to this

o->value.action.type = CompBindingTypeKey;

I am not sure why the others have it set as 0, but this fixed this particular one ;)

Actually, there is something about gconf which modifies action options when things are loaded from gconf, so if you have not installed the schema certain things might not work correctly (I think)

[RAOF]

Thanks, that worked :).

Now I get to see that the patch is broken in other ways :).

Oh, and that TeXmacs doesn't seem to be properly supported by the group code.

[mikedee]

Oh, and that TeXmacs doesn't seem to be properly supported by the group code.

Not sure what this means, I assume its something to do with your editor... dunno either way ;)

EDIT : I see what you mean now (just playing with the scale group code :))... It doesn't seem to work for a lot of apps.

By the way, compiz uses strange indenting. It uses tabs which are 8 spaces wide, but each indent is 4 spaces wide, this means that every other indent needs to be made up with spaces (if that makes sense). Set your editor to use tabs which are 8 wide and set to show spaces if possible. There should be no trailing spaces or spaces on a line by themselves.

[RAOF]

What? So it uses tabs and spaces for indentation? That's weird.

Anyway, got an emacs modeline for it? :)

Also, I fixed the other problem, which was also trivial. Expect to see a patch on the mailinglist soon. Thanks for the help!

[mikedee]

What? So it uses tabs and spaces for indentation? That's weird.

Yes and yes :)

Anyway, got an emacs modeline for it? :)

No

[Vasek]

VIm does this.

[RAOF]

I left my vim fingers on my other pair of hands.